search

compilerla / compiler.la

Compiler's website
https://compiler.la
Apache License 2.0
4 stars 2 forks source link

Feat: implement "Ready to work together?" section of /our-work page #221

Closed lalver1 closed 2 months ago

lalver1 commented 2 months ago

Closes #214

lalver1 commented 2 months ago

Yep, that's a good point 👍 I used an include with a parameter to set the color of the text (because the background of the section in /our-work is black but it is white in /about) and a conditional tag to set the class.

I could remove the conditional by using the default filter:

<h3 class="{{ include.h3-class | default: "" }}">Ready to work together?</h3>

but having <h3 class="">Ready to work together?</h3> in the rendered HTML of /our-work didn't look right.

The include would be much simpler if the background of the section was the same for both /about and /our-work (no parameters to pass or any conditional tags) but I'm not sure if we should deviate from what we have in Figma?

thekaveman commented 2 months ago

I think this is fine. It can be more flexible to avoid sending the specific class as part of the configuration, maybe instead a light or dark mode where the include then decides which classes to use etc.

But this will work and we can always revisit when we need to use this component again.