search

compilerla / conventional-pre-commit

A pre-commit hook that checks commit messages for Conventional Commits formatting
Apache License 2.0
348 stars 59 forks source link

Add to https://pre-commit.com/hooks.html #24

Closed wholtz closed 1 year ago

wholtz commented 2 years ago

Thanks for the useful hook!

You might consider adding it to https://pre-commit.com/hooks.html so that it is easier for others to discover.

thekaveman commented 2 years ago

Thanks for the suggestion @wholtz! I submitted a PR over there.

There is perhaps a question of the maintainers adding new language: script type hooks (of which this hook is one) to the page, but maybe an exception can be made in this case since our hook/script is so simple!

thekaveman commented 1 year ago

@wholtz after much back and forth with the maintainer of https://pre-commit.com, including completely re-writing this hook in Python to avoid language: script, they have declined to accept our PR to add this hook to the list.

I recommend opening a new Issue / PR over there if this is something you would still like to pursue. We appreciate the suggestion nonetheless!