search

compilerla / conventional-pre-commit

A pre-commit hook that checks commit messages for Conventional Commits formatting
Apache License 2.0
336 stars 55 forks source link

Consider reimplementing in Python #25

Closed thekaveman closed 2 years ago

thekaveman commented 2 years ago

This would follow pre-commit recommended best-practice, to take full advantage of the framework and reduce (remove) external dependencies.

From pre-commit/pre-commit.com#691

it appears to require a modern bash as well as grep -- it would be better if implemented in python -- or really the whole script can be replaced with a pygrep regex

Tangentially related to #16 but that approach would have also been not as "best-practice".