compilerla / conventional-pre-commit

A pre-commit hook that checks commit messages for Conventional Commits formatting
Apache License 2.0
348 stars 59 forks source link

Default message from merge commit should be allowed #39

Closed fiksn closed 2 years ago

fiksn commented 2 years ago

Something like Merge branch .* into .* should still ok or am I mistaken?

angela-tran commented 2 years ago

Hi @fiksn -

Thanks for the question! I believe https://github.com/compilerla/conventional-pre-commit/pull/19#issuecomment-1133434301 has the answer.

If anyone is curious, I found some additional discussion about this topic:

thekaveman commented 2 years ago

Thanks for the suggestion @fiksn.

@angela-tran has it right though, we'd like to keep this focused on conventional commits formatting. Local merge commit messages can be customized, or you can avoid the check entirely with the --no-verify flag, e.g.

git merge branch --no-verify