search

compiling-to-categories / concat

Compiling to Categories
http://conal.net/papers/compiling-to-categories
BSD 3-Clause "New" or "Revised" License
431 stars 49 forks source link

Zap some obsolete nix files #112

Closed kenranunderscore closed 12 months ago

kenranunderscore commented 12 months ago

We've just switched to using the flake, and AFAIK we were the only ones using the previous nix files. Those have also become slightly incompatible over time. (Let me know if you still need them @sellout, then I'll close this. I've not found any usage in the remaining nix files.)

sellout commented 12 months ago

This is great – I’ve confused myself a couple times with those files.

I think the only thing still used from that era is netlist-overlay.nix, which you’ve left alone. I’m pretty sure the style of that already matches the flake, so seems like this cleans up everything nicely.

Considering the non-flake files aren’t tested or anything (and apparently no longer working, as you say), I think it’s good to go once the build succeeds. We can revert (and fix) if it turns out there are still users out there.

Any thoughts, @mikesperber?

mikesperber commented 12 months ago

Any thoughts, @mikesperber?

@sellout No - I defer to @kenranunderscore on matters Nix, but we've discussed those changes.

OK to merge?

sellout commented 12 months ago

Arg – I just noticed that master has also had a failing build since the flake got merged.

I doubt this change has had any effect on the failures, but if one of you could spot-check it against master’s failures before merging, that’d be great. Otherwise I can in a couple hours … and then I’ll get the failing checks passing after this is merged (and probably mark some checks as required).

kenranunderscore commented 12 months ago

I checked 2 or 3 jobs against the currently known failures (divergence between nix build and cabal builds in golden tests; broken concat-hardware) and they seemed to match, but I wasn't very thorough. I can check more of them tomorrow. There are some I don't know well that took very long but that's probably due to everything having to be rebuilt.

sellout commented 12 months ago

Ah yeah, now that you mention it, I remember this coming up when we added the flake: https://github.com/compiling-to-categories/concat/pull/111#discussion_r1122078378

I think this is good.

sellout commented 12 months ago

Ok, I protected the master branch, added required checks (which is a pain to do, but hopefully I only selected ones that are currently passing).

@mikesperber – feel free to remove restrictions if they’re too much. I tried to leave it pretty open.

And I’d love to enable the merge queue, but I want to have a better sense of it first.