search

compiling-to-categories / concat

Compiling to Categories
http://conal.net/papers/compiling-to-categories
BSD 3-Clause "New" or "Revised" License
431 stars 49 forks source link

ghc 9.4 support #113

Closed mikesperber closed 9 months ago

mikesperber commented 12 months ago

Port to ghc 9.4.5.

kenranunderscore commented 9 months ago

I can confirm that the concat plugin works well with GHC 9.4, based on these changes in our fork. We are using a newer version though, 9.4.6 (and will probably be switching to 9.4.8 once/if it is released).

Don't know about the garnix and CI stuff, though. Maybe @sellout can chime in here? :)

(Also, am I imagining things, or didn't we have the 9.0 build failing before using cabal v2-build, but work with Nix, and now the CI seems to show the same (number of) failing tests, but for 9.2 :thinking: )

mikesperber commented 9 months ago

The GH workflow for 9.2 is also failing, but that’s due to gold tests, which I think were failing before this PR anyway?

Yes. There's some weird problem where building via Nix changes ghc's inlining strategy slightly as compared to Cabal. We'll have another look at it once this is merged.

kenranunderscore commented 9 months ago

Just FYI, I'm quite certain that the "5 out of 83 tests" in the gold test suite failed on a different GHC version before (9.0) and has since "moved up" to now fail on 9.2 instead. Very weird; see https://github.com/compiling-to-categories/concat/pull/111#discussion_r1122078378

mikesperber commented 9 months ago

Moving this to master now.