search

compiling-to-categories / concat

Compiling to Categories
http://conal.net/papers/compiling-to-categories
BSD 3-Clause "New" or "Revised" License
436 stars 50 forks source link

Fix concat-satisfy on GHC 9.2.1 #114

Closed sellout closed 9 months ago

sellout commented 9 months ago

This broadens the CI coverage and fixes an issue that was missed by testing 9.2.4 instead of 9.2.1.

sellout commented 9 months ago

Unfortunately, 83f06ae9e0c2629dde505ff678e186586a905a66 seems to have broken concat-plugin on everything before GHC 9.4. I think it was probably difficult to notice because there were already a bunch of broken checks due to gold tests, etc. So I added branch protection to master so that the checks passing (as of this PR) are marked required, and we can hopefully tighten that going forward.

I don't use concat-plugin, so the remaining breakage doesn't affect me, but the fixes here address failures in concat-satisfy and concat-classes that do.

mikesperber commented 9 months ago

Thanks, @sellout. I was going to investigate the CI failures (plugin works for me, as do the gold tests), but ran out of time. I'll get back to it next week.

Meanwhile, my experience has been that there's no version jump in ghc that doesn't hold the risk of breaking changes. So I suggest also adding the latest known version along each 9.x line at least.