search

compiling-to-categories / concat

Compiling to Categories
http://conal.net/papers/compiling-to-categories
BSD 3-Clause "New" or "Revised" License
431 stars 49 forks source link

Reverse examples/plugin dependency relationship. #91

Closed sellout closed 1 year ago

sellout commented 2 years ago

This moves tests that depend on the plugin from concat-examples to concat-plugin. The one shortcoming, IMO, is that it requries duplicating the SMT flag.

sellout commented 2 years ago

It would be helpful for us to have this change in.

sellout commented 2 years ago

I'm happy to push a version of this without the GH CI, if that'd get it merged.

mikesperber commented 1 year ago

This looks good to me. @conal, any objection to us merging this one?

mikesperber commented 1 year ago

Just rebased & merged it.

conal commented 1 year ago

Sorry I forgot about this one.

Do all of the examples still build and work, including graphics (WebGL) and SMT?

mikesperber commented 1 year ago

So graphics builds, and test suites run. SMT compiles - is there a test suite or example for that one?

mikesperber commented 1 year ago

(I.e. @conal, I see the comment about this in the README, but don't see what exactly I should uncomment in Test/Examples.hs.)

conal commented 1 year ago

@mikesperber Thanks. I don't remember how to test SMT, and I'm happy to assume that it'll work out fine (or doesn't matter).