Feature/update electron

complexdatacollective / Server

A tool for storing, analyzing, and exporting Network Canvas interview data.

http://networkcanvas.com/

GNU General Public License v3.0

2 stars 2 forks source link

Feature/update electron #257

Closed rebeccamadsen closed 5 years ago

rebeccamadsen commented 5 years ago

Updates electron to 5.0.9, node to 12.8.0, and npm to 6.10.2. Will need to run npm install. On windows, will also need to rebuild mdns to target this version of electron.

cd node_modules\mdns
node-gyp rebuild --target=5.0.9 --arch=x64 --dist-url=https://atom.io/download/electron

Note: this does not yet update react, cordova, or the various other dependencies, so we can separate concerns in the updating process.

wwqrd commented 5 years ago

~I get an error RE menuitems when trying to run electron, wasn't able to continue further for testing~

Fixed: copied the label: 'App', fix from the Network Canvas update.

wwqrd commented 5 years ago

Looks good to me! No problems with UI, connects with NC, export works.

jthrilly commented 5 years ago

@rebeccamadsen - merge whenever you're happy :)