Update to latest node/electron (match Network Canvas)

complexdatacollective / Server

A tool for storing, analyzing, and exporting Network Canvas interview data.

http://networkcanvas.com/

GNU General Public License v3.0

2 stars 2 forks source link

Update to latest node/electron (match Network Canvas) #279

Closed wwqrd closed 4 years ago

wwqrd commented 4 years ago

Updates dependencies to match those used in Network Canvas.

node, 12.8.0 -> 12.14.1
npm, 6.10.2 -> 6.13.4
electron, 5.0.9 -> 9.0.0 😃
electron-log is updated to v4 to support the new electron IPC changes

wwqrd commented 4 years ago

@rebeccamadsen those bugs should be fixed now 🤞

rebeccamadsen commented 4 years ago

I still get the electron-notarize error....

jthrilly commented 4 years ago

electron-notarize is a macOS specific build dependency that I added a little while back. It is probably not being installed on your platform, since it won't work there. I'm not sure why this wasn't an issue before, though. @rebeccamadsen - can you check if master behaves the same way?

rebeccamadsen commented 4 years ago

I can run dist:win on master without issue. I'm not sure why it should matter, either.

wwqrd commented 4 years ago

I've added the electron-notorize dependency to package.json

rebeccamadsen commented 4 years ago

This helps the build complete, and installs, but opening the installed application, the app just crashes immediately after opening. Running the installed app on the command line, I see this error:

16:42:11.636 > unhandledRejection: Error: An object could not be cloned.
    at EventEmitter.t.ipcRendererInternal.send.t.ipcRendererInternal.send (electron/js2c/renderer_init.js:126:332)
    at EventEmitter.<anonymous> (electron/js2c/renderer_init.js:122:328)

Maybe this is related to this: https://www.electronjs.org/docs/breaking-changes#behavior-changed-sending-non-js-objects-over-ipc-now-throws-an-exception