search

complexdatacollective / Server

A tool for storing, analyzing, and exporting Network Canvas interview data.
http://networkcanvas.com/
GNU General Public License v3.0
2 stars 2 forks source link

New Update Mechanism #302

Closed jthrilly closed 3 years ago

jthrilly commented 3 years ago

This PR replaces electron-updater with the same system used in complexdatacollective/Interviewer#1091

Please see that PR for details.

rebeccamadsen commented 3 years ago

I could not test this one. There was a linting error, and this error when installing the dist:win build:

install error

This error happens in master though so either we missed something in reviewing previous PRs or I'm doing something wrong.

rebeccamadsen commented 3 years ago

I still get the "eventemitter" error on a dist:win release build. Running in development mode, the prompt to upgrade doesn't show even if I set my version to 5.0.0.

jthrilly commented 3 years ago

Okay @rebeccamadsen - I think I finally worked out the issues with that. Give it one last whirl, please!

rebeccamadsen commented 3 years ago

The version change works! And I can build the release build now too.

However, now when I click on the "Show Release Notes" button, I just get this error on the console and nothing happens:

Uncaught TypeError: Cannot destructure property 'buttonText' of 'releaseButtonContent' as it is undefined.
    at showReleaseNotes (useUpdater.js:92)
    at onClick (useUpdater.js:145)
    at HTMLUnknownElement.callCallback (react-dom.development.js:188)
    at Object.invokeGuardedCallbackDev (react-dom.development.js:237)
    at invokeGuardedCallback (react-dom.development.js:292)
    at invokeGuardedCallbackAndCatchFirstError (react-dom.development.js:306)
    at executeDispatch (react-dom.development.js:389)
    at executeDispatchesInOrder (react-dom.development.js:414)
    at executeDispatchesAndRelease (react-dom.development.js:3278)
    at executeDispatchesAndReleaseTopLevel (react-dom.development.js:3287)
    at forEachAccumulated (react-dom.development.js:3259)
    at runEventsInBatch (react-dom.development.js:3304)
    at runExtractedPluginEventsInBatch (react-dom.development.js:3514)
    at handleTopLevel (react-dom.development.js:3558)
    at batchedEventUpdates$1 (react-dom.development.js:21871)
    at batchedEventUpdates (react-dom.development.js:795)
    at dispatchEventForLegacyPluginEventSystem (react-dom.development.js:3568)
    at attemptToDispatchEvent (react-dom.development.js:4267)
    at dispatchEvent (react-dom.development.js:4189)
    at unstable_runWithPriority (scheduler.development.js:653)
    at runWithPriority$1 (react-dom.development.js:11039)
    at discreteUpdates$1 (react-dom.development.js:21887)
    at discreteUpdates (react-dom.development.js:806)
    at dispatchDiscreteEvent (react-dom.development.js:4168)