search

complexdatacollective / Server

A tool for storing, analyzing, and exporting Network Canvas interview data.
http://networkcanvas.com/
GNU General Public License v3.0
2 stars 2 forks source link

Export data does not work in development mode #318

Closed wwqrd closed 3 years ago

wwqrd commented 3 years ago

Export appear to complete before a destination path has been defined. Once a path is chosen the dialog is shown as being "cancelled" in the console logs.

Seems to work fine from an app build.

jthrilly commented 3 years ago

I can't reproduce this with a fresh checkout of master, fresh submodule update, and fresh npm inbstall.

One thing is that the export is supposed to complete before the path is chosen. This was changed when network-exporters was re-written. The thinking is that it is a save dialog rather than a path choosing dialog - there might not be anything to save if the export fails.

jthrilly commented 3 years ago

@rebeccamadsen can you try and verify?

rebeccamadsen commented 3 years ago

Export worked for me in dev mode with NC data and generated data. Was there anything of note in the settings you used that didn't work?

wwqrd commented 3 years ago

Sounds like there might be a fault on my system/linux.

Just to clarify on the "Export appear to complete before a destination path has been defined" comment, in the release version this doesn't flag as export complete until I have selected a destination path. Example:

Screenshot from 2021-01-18 11-48-46

Where as in development version the toast is showing complete (at which point if you wait a moment it will entirely expire), once the destination is selected I see the error in the console about the dialog being cancelled.

Screenshot from 2021-01-18 11-53-34

This is with a fresh clone and install.

wwqrd commented 3 years ago

On a fresh Linux install I am unable to reproduce, so it's likely this was something wrong at my end.