search

complexdatacollective / Server

A tool for storing, analyzing, and exporting Network Canvas interview data.
http://networkcanvas.com/
GNU General Public License v3.0
2 stars 2 forks source link

Feature/entity resolution v1 eslint #327

Closed jthrilly closed 3 years ago

jthrilly commented 3 years ago

Looks like the TopPanel test is failing. Maybe withRouter was passed through somewhere?

wwqrd commented 3 years ago

How does this compare with your changes? Much difference?

jthrilly commented 3 years ago

Looks the same to me! I didn't have the testing stuff in devDependencies.

wwqrd commented 3 years ago

Ah, yeah electron warned about it, and supertest is obviously a testing framework so I moved it there. restify-errors should actually be a dependency so I've moved it. Honestly find the split a lot more intelligible than the react-backed "put everything in dev because it's compiled" way of doing things.

jthrilly commented 3 years ago

Agreed!