search

complyue / OscBrain

BSD 3-Clause "New" or "Revised" License
1 stars 2 forks source link

CustomJSTickFormatter is deprecated and needs to be updated with FuncTickFormatter #1

Open aryabhatta000 opened 9 months ago

aryabhatta000 commented 9 months ago

There are 3 notebook where CustomJSTickFormatter is used, which may require updating.

  1. bkh.py all [ " " ]
  2. sim.py class LetterNetSim init p.yaxis.formatter
  3. init.py all "bokeh exports"

I tried updating the notebooks at my end, but was unable to see the ticks on the plots (it remains blank).

image

complyue commented 9 months ago

do you see error logs in your browser's console? that'll help diagnose the root cause. your pic seems to have tick labels rendered properly, not looks like the real cause.

aryabhatta000 commented 9 months ago

Hello Complyue, could it have been because I had updated your code in above 3 places - with FuncTickFormatter?

But unable to get the same result as you had shared on the HTM forum here.

image

I am currently using the docker version shared by indy on HTM forum here. Thus will attempt to try what you have suggested, though haven't done much trouble shooting using browser console.

Anyways, I am grateful for your work here, for it has definitely helped me understand a bit more on how to organize the code.

complyue commented 9 months ago

I reproduced your plot result via Gitpod https://gitpod.io/#https://github.com/complyue/OscBrain, and it seems that bcoz of Bokeh won't work with Jupyter Notebook 7, hopefully Bokeh has an issue marked closed to address a similar problem, but only for version 3.4 which is yet not released. Before that, I verified that downgrade Jupyter Notebook to 6.5.3 can fix the problem, and pushed the change so the Gitpod link will give you a working env.

In case you work with your own env, try conda install notebook=6.x and I expect that'll fix it. No need to modify js code.