compneurobilbao / ageml

AgeML is a Python package for Age Modelling with Machine Learning made easy.
Apache License 2.0
5 stars 1 forks source link

Standardisation of Code Structure and Naming #28

Open JGarciaCondado opened 5 months ago

JGarciaCondado commented 5 months ago

Although efforts have been made to have clear code and more structured code this can be improved.

Improvements should focus in standardising how/when self is called, what inputs and outputs different functions have (especially looking at the interface object where each method seems to be doing their own thing). Naming conventions should be established.

In terms of code clarity:

In terms of messaging:

In terms of structure: We should reconsider how the software package works and different objects interact with each other. Maybe a UML structure diagram could help.

Requirements to close the issue:

JGarciaCondado commented 5 months ago

I guess also another standardisation that should be thought of would be the files and their format. For example, in the clinical file we are using TRUE and FALSE. Maybe we should use 0 and 1 which are used more commonly?