search

compomics / DeepLC

DeepLC: Retention time prediction for (modified) peptides using Deep Learning.
https://iomics.ugent.be/deeplc
Apache License 2.0
52 stars 18 forks source link

scikit-learn / sklearn missing from dependency list #37

Closed RalfG closed 2 years ago

RalfG commented 2 years ago

sklearn is missing as a dependency in setup.py and the conda yaml file: https://github.com/bioconda/bioconda-recipes/blob/master/recipes/deeplc/meta.yaml

The GitHub Actions tests pass, as sklearn was already a test dependency. The bioconda tests fail, however: https://github.com/bioconda/bioconda-recipes/pull/32320

The sklearn dependency seems to have been added in https://github.com/compomics/DeepLC/commit/675f5ab676e33ed4f7eee9824a830417f647664e

RobbinBouwmeester commented 2 years ago

@paretje Indeed, making this import optional is probably best. With latest merged PR 675f5ab is this fixed?

RalfG commented 2 years ago

Fixed in #38