compomics / compomics-utilities

Open source Java library for computational proteomics
http://compomics.github.io/projects/compomics-utilities.html
30 stars 17 forks source link

IdentificationParametersCLI command line error #8

Closed im281 closed 8 years ago

im281 commented 8 years ago

Hello, I keep getting an error while trying to run the IdentificationParametersCLI to create a parameters file.The command line I typed are below and the error is below that. Any suggestions would be appreciated.

java -cp SearchGUI-2.2.2.jar eu.isas.searchgui.cmd.IdentificationParametersCLI -db "C:\SearchGUI-2.2.2\testfiles\my.fasta" -xtandem_npeaks 23 -out "c:\search_parameters.par" java.lang.NullPointerException at com.compomics.util.preferences.IdentificationParameters.saveIdentificationParameters(IdentificationParameters.java:421) at com.compomics.util.experiment.identification.parameters_cli.AbstractIdentificationParametersCli.call(AbstractIdentificationParametersCli.java:107) at com.compomics.util.experiment.identification.parameters_cli.AbstractIdentificationParametersCli.initiate(AbstractIdentificationParametersCli.java:84) at eu.isas.searchgui.cmd.IdentificationParametersCLI.(IdentificationParametersCLI.java:25) at eu.isas.searchgui.cmd.IdentificationParametersCLI.main(IdentificationParametersCLI.java:36)

hbarsnes commented 8 years ago

Hi.

There seems to be a bug in our code when creating a new parameter file via the command line. We'll come up with fix and release a new version as soon as possible.

In the meantime you can always create the parameter file via the graphical user interface and then use it in your command lines. (Editing them via the command line should also be possible, as the bug above only seems to affect the creation of new parameters files.)

Best regards, Harald

im281 commented 8 years ago

Thanks! Can't wait for the fix!

On Fri, Dec 25, 2015, 5:10 PM Harald Barsnes notifications@github.com wrote:

Hi.

There seems to be a bug in our code when creating a new parameter file via the command line. We'll come up with fix and release a new version as soon as possible.

In the meantime you can always create the parameter file via the graphical user interface and then use it in your command lines. (Editing them via the command line should also be possible, as the bug above only seems to affect the creation of new parameters files.)

Best regards, Harald

— Reply to this email directly or view it on GitHub https://github.com/compomics/compomics-utilities/issues/8#issuecomment-167269213 .

im281 commented 8 years ago

Looks like that bug is not fixed in 2.3.0 even though it says it was fixed in the release notes...

im281 commented 8 years ago

It appears that a input.par file created by the GUI can also not be saved

SearchGUI-2.3.0>java -cp SearchGUI-2.3.0.jar eu.isas.searchgui.cmd.IdentificationParametersCLI -db "C:\folder\myo.fasta" -out "C:/Users//Documents/idparams.par"

java.lang.NullPointerException at com.compomics.util.preferences.IdentificationParameters.saveIdentificationParameters(IdentificationParameters.java:421) at com.compomics.util.experiment.identification.parameters_cli.AbstractIdentificationParametersCli.call(AbstractIdentificationParametersCli.java:116) at com.compomics.util.experiment.identification.parameters_cli.AbstractIdentificationParametersCli.initiate(AbstractIdentificationParametersCli.java:93) at eu.isas.searchgui.cmd.IdentificationParametersCLI.(IdentificationParametersCLI.java:25) at eu.isas.searchgui.cmd.IdentificationParametersCLI.main(IdentificationParametersCLI.java:36)

hbarsnes commented 8 years ago

Not sure which line in the release notes you are referring to, but I can confirm that the bug has not yet been fixed. Especially given that version 2.3.0 was released before I replied to your comments. :-)

As for the line above regarding that a parameter file created in the GUI cannot be saved, I'm not sure what you mean? As the example above does not use a GUI generated parameter file at all?

hbarsnes commented 8 years ago

And in case it is unclear from the documentation, if you want to use se GUI generated parameter file on the command line you have use the -id_params option. And in that case the -out option is not needed unless you want to make changes to the parameter file and resave it.

im281 commented 8 years ago

Ok thanks Herald!

On Sat, Dec 26, 2015, 1:20 PM Harald Barsnes notifications@github.com wrote:

And in case it is unclear from the documentation, if you want to use se GUI generated parameter file on the command line you have use the -id_params option. And in that case the -out option is not needed unless you want to make changes to the parameter file and resave it.

— Reply to this email directly or view it on GitHub https://github.com/compomics/compomics-utilities/issues/8#issuecomment-167364080 .

im281 commented 8 years ago

Hi Herald, is the problem fixed in 2.3.2? It doesn't appear to be fixed? Thanks!

Changes in SearchGUI 2.3.1 (December 28. 2015):

BUG FIX: Fixed a bug in the creation of an identification settings file via the GUI. LIBRARY UPDATE: Updated utilities to version 4.3.4.

hbarsnes commented 8 years ago

Hi.

No, it was not fixed in version 2.3.2 (that issue was a related one but only when the file was created via the graphical user interface), but the issue has now been corrected and the fix will be in the next release. I will let you know when it becomes available.

Best regards, Harald

hbarsnes commented 8 years ago

Hi.

With the release of SearchGUI v2.3.3 and PeptideShaker v1.3.3 this issue has now been fixed. If this is not the case on your side please let us know and we'll reopen the issue.

Sorry it took so long, but you detect the issue at the worst time, i.e. right before the holidays. ;)

Best regards, Harald

im281 commented 8 years ago

No worries! I will check it out this evening... Your program looks very promising!!

im281 commented 8 years ago

Thanks! It is working!!!

On Tue, Jan 5, 2016 at 12:37 PM Harald Barsnes notifications@github.com wrote:

Hi.

With the release of SearchGUI v2.3.3 and PeptideShaker v1.3.3 this issue has now been fixed. If this is not the case on your side please let us know and we'll reopen the issue.

Sorry it took so long, but you detect the issue at the worst time, i.e. right before the holidays. ;)

Best regards, Harald

— Reply to this email directly or view it on GitHub https://github.com/compomics/compomics-utilities/issues/8#issuecomment-169125821 .

im281 commented 8 years ago

Hi Herald, Is there a way to run SearchGUI using C#? For example:

System.Diagnostics.Process clientProcess = new Process(); clientProcess.StartInfo.FileName = "java.exe"; clientProcess.StartInfo.Arguments = "-jar" + " " + @"SearchGUI-2.3.3\SearchGUI-2.3.3.jar" + [parameters]; clientProcess.Start();

When I run this the splash screen pops up but no processing. The command line works though.

On Tue, Jan 5, 2016 at 5:02 PM Iman Mohtashemi iman.mohtashemi@gmail.com wrote:

Thanks! It is working!!!

On Tue, Jan 5, 2016 at 12:37 PM Harald Barsnes notifications@github.com wrote:

Hi.

With the release of SearchGUI v2.3.3 and PeptideShaker v1.3.3 this issue has now been fixed. If this is not the case on your side please let us know and we'll reopen the issue.

Sorry it took so long, but you detect the issue at the worst time, i.e. right before the holidays. ;)

Best regards, Harald

— Reply to this email directly or view it on GitHub https://github.com/compomics/compomics-utilities/issues/8#issuecomment-169125821 .

hbarsnes commented 8 years ago

The last question is a duplicate of https://github.com/compomics/peptide-shaker/issues/108. I will therefore reply to the question there.

Please limit the same question to a single issue on the future (and preferably don't add new questions to old closed issues), as otherwise it becomes very time consuming for us to keep track of all the issues. :)

im281 commented 8 years ago

ok sorry about that, didn't know where to post the question