search

compomics / moFF

A modest Feature Finder (moFF) to extract MS1 intensities from Thermo raw file
Apache License 2.0
33 stars 11 forks source link

Some path changes for conda #22

Closed caleb-easterly closed 6 years ago

caleb-easterly commented 6 years ago

Hi,

I'm working on writing a conda recipe for moFF, for ease of distribution and so we can later incorporate it into Galaxy. Because conda uses some symbolic links, I added os.path.realpath to a few paths, so that the symlinks are followed to the target. I don't think this should affect usage outside of conda.

I also added simplejson and pymzml to requirements/development.txt and then added the bioconda channel in .travis.yml, which is the only way I could get moFF to build on Travis (I think pymzml is only in bioconda.

Anyway, let me know what you think!

caleb-easterly commented 6 years ago

Also, if you would prefer to not make these changes in the main code, I can patch the code when I put it into conda. Either way is fine with me.

bgruening commented 6 years ago

With some luck this will also fix https://github.com/compomics/moFF/pull/17

caleb-easterly commented 6 years ago

Thanks, @Maux82! If you'd like to make a new release with these changes and any others, I can point the conda recipe to the new release (they prefer referencing releases rather than repositories at a certain state).