compomics / ms2pip

MS²PIP: Fast and accurate peptide spectrum prediction for multiple fragmentation methods, instruments, and labeling techniques.
https://ms2pip.readthedocs.io
Apache License 2.0
38 stars 18 forks source link

SinglePrediction: Off-by-1 bug in conversion from ms2pip to spectrum_utils modification notation? #170

Closed RalfG closed 1 year ago

RalfG commented 2 years ago

Should this be int(loc) - 1? https://github.com/compomics/ms2pip_c/blob/f951d423921b50cfd86b1417241fb95410cbfc08/ms2pip/single_prediction.py#L246