Currently broken - Githubissues

compomics / ms2pip

MS²PIP: Fast and accurate peptide spectrum prediction for multiple fragmentation methods, instruments, and labeling techniques.

https://ms2pip.readthedocs.io

Apache License 2.0

37 stars 18 forks source link

Currently broken #28

Closed rohan-shah closed 5 years ago

rohan-shah commented 5 years ago

We really want to use this, but there appear to be a very large number of bugs. For example:

File ../models/HCD/pkl_B_4deep.c does not exist, should this be ../models/HCD/pklB9deep.c?
There is an else if without a beginning if in cython_modules/ms2pip_peaks_c.c, due to commenting?
Functions score_B_zero, score_B_one, score_B_left, score_Y_one, score_Y_left are all undefined.
The install instructions don't work, as they are written.

RalfG commented 5 years ago

Hi! Did you download the latest release, as written in the README.md? Because the most recent commit in the master branch indeed contains some bugs. I also recommend you to extract the precompiled files (see the ms2pip_c_v20190130_precompiled_cython_modules.zip on the releases page) into the cython_modules folder, as compiling them yourself can take a very long time. For this to work, you do need Python 3.7 (can be a conda env). Let me know if it works!