compomics / ms2rescore

Modular and user-friendly platform for AI-assisted rescoring of peptide identifications
https://ms2rescore.readthedocs.io
Apache License 2.0
39 stars 14 forks source link

Suggest correction for comet pin file #86

Closed progistar closed 8 months ago

progistar commented 1 year ago

Hello,

First of all, thank you for maintaining this nice software. I leave some comments for more comprehensive manuals (for comet pin).

  1. Change below code. When I applied below, it works well for comet pin file also.

id_file_parser.py line number 46~48 change "retention_times[index] = float(line[12:].strip())" to "retention_times[titles[index]] = float(line[12:].strip())"

  1. Please add explicit explanation about that the column name "lnExpect" must be changed to "COMET:lnExpect" to avoid "psm_score" null point error.

I am glad to share this information with future users ^^*.

RalfG commented 8 months ago

Hi @progistar,

Thank you for sharing! We have just released a new beta for MS²Rescore 3.0, which now uses psm_utils for reading PSM files, such as PIN. It should be a lot more robust towards parsing issues such as the one you mentioned.

Definitely let us know when you run into any other issues.

Thanks!