compomics / peptide-shaker

Interpretation of proteomics identification results
http://compomics.github.io/projects/peptide-shaker.html
48 stars 19 forks source link

exportFactory problem #448

Closed bernt-matthias closed 3 years ago

bernt-matthias commented 3 years ago

On PS 2.0.15 (via Galaxy) we observe:

java.io.FileNotFoundException: /work/songalax/galaxy/database/jobs_directory/000/107/107722/working/PeptideShakerCLI/exportFactory.json (No such file or directory)
    at java.base/java.io.FileInputStream.open0(Native Method)
    at java.base/java.io.FileInputStream.open(FileInputStream.java:219)
    at java.base/java.io.FileInputStream.<init>(FileInputStream.java:157)
    at com.compomics.util.io.json.JsonMarshaller.getJsonStringFromFile(JsonMarshaller.java:227)
    at com.compomics.util.io.json.JsonMarshaller.fromJson(JsonMarshaller.java:142)
    at eu.isas.peptideshaker.export.PSExportFactory.loadFromFile(PSExportFactory.java:158)
    at eu.isas.peptideshaker.export.PSExportFactory.getInstance(PSExportFactory.java:99)
    at eu.isas.peptideshaker.cmd.ReportCLIParams.<clinit>(ReportCLIParams.java:17)
    at eu.isas.peptideshaker.cmd.PeptideShakerCLIParams.createOptionsCLI(PeptideShakerCLIParams.java:76)
    at eu.isas.peptideshaker.cmd.PeptideShakerCLI.main(PeptideShakerCLI.java:1370)

The odd thing is that the file is there (I checked its existence before and after the run):

file /work/songalax/galaxy/database/jobs_directory/000/107/107722/working/PeptideShakerCLI/exportFactory.json:

/work/songalax/galaxy/database/jobs_directory/000/107/107722/working/PeptideShakerCLI/exportFactory.json: ASCII text

Content is:

{
  "userSchemes": {}
}
CarlosHorro commented 3 years ago

Hi @bernt-matthias ,

Just to mention that this exception does not imply any malfunctioning but it clarifies that the exportFactory.json does not exist and it will be created. However, after managing some other bugs we will improve it in order to avoid any confusion.

Greetings, Carlos

bernt-matthias commented 3 years ago

Thanks for the info. Then we should think about if we should

hbarsnes commented 3 years ago

or make SG/PS indicate such things in a different way.

@bernt-matthias It will be replaced by a normal text message in the next release.

hbarsnes commented 3 years ago

A new version has just been deployed where the stack trace is no longer being printed.