compomics / searchgui

Highly adaptable common interface for proteomics search and de novo engines
http://compomics.github.io/projects/searchgui.html
40 stars 16 forks source link

Changes to peptide length range not being saved for Comet #285

Closed kevinkovalchik closed 3 years ago

kevinkovalchik commented 3 years ago

Hello!

When I change the peptide length range in the Comet Advanced Settings it isn't triggering a prompt to save the changes when I close the settings window, and when reopening the settings the peptide lengths are back to the defaults. If I change the peptide length and another setting then I am prompted to save the changes, but when reopening the settings the peptide length remains at the default.

For other search engines this doesn't seem to happen.

I've found this is in v4.0.18 and also an copy of v4.0.3 I have. I'm using the Linux versions.

Best wishes, Kevin

hbarsnes commented 3 years ago

Hi Kevin,

Thanks for letting us know! You are indeed correct, neither the min nor the max peptide length value for Comet is actually stored. I'll fix this and release a new version as soon as possible.

Best regards, Harald

kevinkovalchik commented 3 years ago

Okay, thanks!

hbarsnes commented 3 years ago

I've just released SearchGUI 4.0.19 which should solve this problem. If this is not the case, please let me know and I'll reopen the issue.