compomics / searchgui

Highly adaptable common interface for proteomics search and de novo engines
http://compomics.github.io/projects/searchgui.html
40 stars 15 forks source link

Mini Issue: semiArgC missing #71

Closed ulrich-eckhard closed 8 years ago

ulrich-eckhard commented 8 years ago

Maybe I just miss it, but don't find semiArgC predefined in SearchGUI. I can add it of course manually, but then MS Amanda does still not recognize it. possible? thanks in advance, u

hbarsnes commented 8 years ago

Hi Ulrich,

Seems like semi-ArgC was never added. Will be included in the next release. In the future we'll try to get rid of all the semi-enzymes and rather make the semi-specificity a separate option.

For now just add the following at the end of searchGUI_enzymes.xml and peptideshaker_enzymes.xml:

<enzyme>
    <id> 28 </id>
    <name> Semi-Arg-C </name>
    <aminoAcidBefore> R </aminoAcidBefore>
    <restrictionBefore> </restrictionBefore>
    <aminoAcidAfter> </aminoAcidAfter>
    <restrictionAfter> P </restrictionAfter>
    <semiSpecific> yes </semiSpecific>
    <wholeProtein> no </wholeProtein>
</enzyme>

In the next version the MS Amanda enzymes will be generated based on these files. But for now just go into MS Amanda\windows\enzymes_SearchGUI.xml and add:

  <enzyme>
    <name>Semi-Arg-C</name>
    <cleavage_sites>R</cleavage_sites>
    <inhibitors>P</inhibitors>
    <position>after</position>
  </enzyme>

Best regards, Harald

ulrich-eckhard commented 8 years ago

awesome - it works. missed the additional enzyme definition within MS Amanda. big big thanks!!! one more quick question: what are "maximum MGF File Size" and Maximum Spectra in MGF File" exactly doing?. Didn't have a mgf >1GB yet, but I had more than 25k spectra and it searched still all of them. no?

hbarsnes commented 8 years ago

The "Maximum MGF File Size" is just a trick we added to tell SearchGUI when to start splitting the mgf files into smaller pieces. When an mgf file is bigger than the given limit we automatically split it into multiple files, each with as maximum as many spectra as set in the "Maximum Spectra in MGF File" option. (For mgf files smaller than 1 GB the "Maximum Spectra in MGF File" has no impact.) As the PSMs are later merged when loaded in PeptideShaker the impact of the splitting should be minimal, but it is recommended to process the mgf files without splitting when possible.

This was something we added to be able to process files bigger than what was supported by some of the search engines, in particularly OMSSA. For the newer search engines splitting mgfs should not be necessary.

ulrich-eckhard commented 8 years ago

that makes perfectly sense. thanks for that info!

On Mon, Dec 21, 2015 at 10:06 AM, Harald Barsnes notifications@github.com wrote:

The "Maximum MGF File Size" is just a trick we added to tell SearchGUI when to start splitting the mgf files into smaller pieces. When an mgf file is bigger than the given limit we automatically split it into multiple files, each with as maximum as many spectra as set in the "Maximum Spectra in MGF File" option. (For mgf files smaller than 1 GB the "Maximum Spectra in MGF File" has no impact.) As the PSMs are later merged when loaded in PeptideShaker the impact of the splitting should be minimal, but it is recommended to process the mgf files without splitting when possible.

This was something we added to be able to process files bigger than what was supported by some of the search engines, in particularly OMSSA. For the newer search engines splitting mgfs should not be necessary.

— Reply to this email directly or view it on GitHub https://github.com/compomics/searchgui/issues/71#issuecomment-166376915.

hbarsnes commented 8 years ago

SearchGUI 2.3.0 and PeptideShaker 1.3.0 now includes support for Semi-Arg-C out if the box. :)

ulrich-eckhard commented 8 years ago

yeah! happy holidays! On Dec 23, 2015 10:55 AM, "Harald Barsnes" notifications@github.com wrote:

SearchGUI 2.3.0 and PeptideShaker 1.3.0 now includes support for Semi-Arg-C out if the box. :)

— Reply to this email directly or view it on GitHub https://github.com/compomics/searchgui/issues/71#issuecomment-166970073.