search

component-driven / cypress-axe

Test accessibility with axe-core in Cypress
MIT License
621 stars 86 forks source link

Migrating cypress to v10 #130

Closed srikanthkyatham closed 2 years ago

srikanthkyatham commented 2 years ago

This is a breaking change for v10. Major version should be bumped to support this PR.

srikanthkyatham commented 2 years ago

Resolves #126 .

srikanthkyatham commented 2 years ago

Yet to update readme with v9 and below guide and V10 and above related changes. Now the Readme is only specific to V10 cypress.

srikanthkyatham commented 2 years ago

All the updates are done. Waiting for the review comments and next steps.

srikanthkyatham commented 2 years ago

According https://docs.cypress.io/guides/getting-started/installing-cypress#System-requirements

Cypress v10 Nodejs versions supported are

12 or 14 and above.

Perhaps there should be a separate branch or tag for 0.x where we could check on Node 10, 12, 14. For master we could check on 12, 14.

Please guide me.

srikanthkyatham commented 2 years ago

Or drop nodejs v10 as it is not an lts anymore.

srikanthkyatham commented 2 years ago

Dropping nodejs v10 and adding v16 to the workflow.

bmordue commented 2 years ago

Hi @srikanthkyatham , thanks for your contribution. ~Do you want to go ahead and bump the major version for the breaking change?~ No need! Otherwise looks good to me.

github-actions[bot] commented 2 years ago

:tada: This PR is included in version 1.0.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: