Closed DesselBane closed 4 years ago
I'll look at this when I find some time to properly test it. Hopefully soon.
hey @avanslaars! Thanks for a great project. Curious if you're looking for help in the testing process in looking to upgrade to the 3.5 rule set? Were you thinking of manual tests, or adding some integration tests via actually executing Cypress?
I'd think that automated tests would make the verification process a lighter lift for you. If you're aligned, I'd be happy to add a light CircleCI integration that asserts that the integration outputs violations.
Idea for testing: a passing build on Circle would verify that exceptions are caught and that the cypress build fails, and fails for the right reason given a rendered page of html. This'd likely mean we'd have to introduce a devDependency of a webserver (express.js?) with a view rendering layer.
Lemmeknow!
@avanslaars is there any updates on this? Will it be helpful if I send a pull request for this change? I'd be happy to do it.
@avanslaars is there any updates on this? Will it be helpful if I send a pull request for this change? I'd be happy to do it.
Sounds like a pull request could be useful
Created a PR above.
Let's keep all versioning discussions in #65.
Update the axe-core package to version <= 3.5.0 to include the 3.5 ruleset