component-driven / cypress-axe

Test accessibility with axe-core in Cypress
MIT License
622 stars 86 forks source link

Update axe-core to >= 3.5.0 #36

Closed DesselBane closed 4 years ago

DesselBane commented 4 years ago

Update the axe-core package to version <= 3.5.0 to include the 3.5 ruleset

avanslaars commented 4 years ago

I'll look at this when I find some time to properly test it. Hopefully soon.

vanderhoop commented 4 years ago

hey @avanslaars! Thanks for a great project. Curious if you're looking for help in the testing process in looking to upgrade to the 3.5 rule set? Were you thinking of manual tests, or adding some integration tests via actually executing Cypress?

I'd think that automated tests would make the verification process a lighter lift for you. If you're aligned, I'd be happy to add a light CircleCI integration that asserts that the integration outputs violations.

Idea for testing: a passing build on Circle would verify that exceptions are caught and that the cypress build fails, and fails for the right reason given a rendered page of html. This'd likely mean we'd have to introduce a devDependency of a webserver (express.js?) with a view rendering layer.

Lemmeknow!

aldosuwandi commented 4 years ago

@avanslaars is there any updates on this? Will it be helpful if I send a pull request for this change? I'd be happy to do it.

hmniw commented 4 years ago

@avanslaars is there any updates on this? Will it be helpful if I send a pull request for this change? I'd be happy to do it.

Sounds like a pull request could be useful

kristina-hager commented 4 years ago

PR created: https://github.com/avanslaars/cypress-axe/pull/57

kristina-hager commented 4 years ago

Created a PR above.

sapegin commented 4 years ago

Let's keep all versioning discussions in #65.