Closed camshaft closed 10 years ago
I'm not sure if this is the correct repo to open this issue but I'm running into a problem where I depend on a repo that ends in '.js' and the require doesn't get rewritten correctly.
{ "name": "my-component", "scripts": ["index.js"], "dependencies": { "visionmedia/page.js": "1.3.7" } }
var page = require('page');
When I go to build the component I get this output:
// build/build.js /// snip require stuff require.register("my-component", function (exports, module) { var page = require("page"); }); require("my-component")
From my understanding it should look like this instead:
// build/build.js /// snip require stuff require.register("my-component", function (exports, module) { var page = require("visionmedia~page.js@1.3.7"); }); require("my-component")
From what it looks like to me the builder is looking at the repo name instead of the name of the component
name
fixed in 1.1.5. i just had a bad test as noted in https://github.com/component/builder2.js/pull/53, so i had no idea what was going on :(
awesome! thanks
I'm not sure if this is the correct repo to open this issue but I'm running into a problem where I depend on a repo that ends in '.js' and the require doesn't get rewritten correctly.
example
component.json
index.js
When I go to build the component I get this output:
From my understanding it should look like this instead:
From what it looks like to me the builder is looking at the repo name instead of the
name
of the component