search

componentjs / builder2.js

builder for component
50 stars 20 forks source link

don't throw errors for server side require`s #70

Closed timaschew closed 10 years ago

timaschew commented 10 years ago

allow environment check also for locals for instance:

if (typeof window === 'undefined') {
  require('../local-component');
} else {
  require('local-component')
}
jonathanong commented 10 years ago

hmmm i don't really see the reason for this... but why not. also needs a rebase

timaschew commented 10 years ago

yes, I needed this fix and forgot to push it to different branch see #72 and #73

timaschew commented 10 years ago

can anyone publish it to npm please

btw: there is still a mismatch between github (1.1.8) and npmjs (1.1.9) #71 @dominicbarnes did you forgot to commit your changes?

dominicbarnes commented 10 years ago

@timaschew apparently I had forgotten to push to github... I fixed that just now

timaschew commented 10 years ago

@dominicbarnes thanks :) So I prepared everything for pushing it to npm: https://github.com/component/builder2.js/commit/4948df62f5674670e1ce83af7c260c3dbcba493e :smile_cat: