search

componentjs / builder2.js

builder for component
50 stars 20 forks source link

Use canonical name as ID for AMD define() #78

Closed jamesreggio closed 10 years ago

jamesreggio commented 10 years ago

This PR updates the UMD boilerplate to provide an ID argument to the AMD define function, per this specification.

This change is in the interest of making the --standalone function of component-build actually produce a component which can be used in a standalone manner—that is to say, a component that is identified by its name with the AMD loader.

jamesreggio commented 10 years ago

Thanks for the merge, @timaschew. Could you cut a release at some point soon?

timaschew commented 10 years ago

I want to merge some other pull requests for the next version, but for those I need some time, so maybe this weekend ;)

jamesreggio commented 10 years ago

Thanks!