search

componentjs / builder2.js

builder for component
50 stars 20 forks source link

Bump graceful-fs dependency #89

Open ChALkeR opened 8 years ago

ChALkeR commented 8 years ago

graceful-fs versions lower than v4 reevaluate native fs module source, which is not supported. You should update your graceful-fs dependency to v4 or later.

Tracking issue: https://github.com/nodejs/node/issues/5213.

timaschew commented 8 years ago

Does it make sense even if the project is deprecated? https://github.com/componentjs/component#this-project-is-deprecated

ChALkeR commented 8 years ago

@timaschew

  1. This would hard break on Node.js 7.
  2. I'm not exactly sure yet what would happen with Node.js 6, but most likely it would just print deprecation messages. If the warning gets reverted or turned into an error prior to Node.js v6 release (which I personally find unlikely), then v6 will hard break too.
  3. This package still has 24335 downloads/month.
  4. The change is a one-liner and most likely requires only testing.

It's up to you to decide.

Note that I'm not a user of component, I just filed identical issues to several popular packages that depend on the broken graceful-fs version.

timaschew commented 8 years ago

Thank you the info.

I also realized there are so many downloads, but I never trust those stats on npm. I think if anyone is really using component in production which sounds little legacy to me, then you would also stick to an old node.js version. Testing and the fragmentation of component into many npm modules makes testing and releasing not so easy.

So I keep this issue just open an we'll see :)