search

componentjs / component

frontend package manager and build tool for modular web applications
https://github.com/componentjs/guide
MIT License
4.55k stars 306 forks source link

Bitbucket? #548

Closed anthonyshort closed 10 years ago

anthonyshort commented 10 years ago 
error : bitbucket returned mailformed JSON at URL: https://api.bitbucket.org/1.0/repositories/ripplejs/ripple/raw/0.23.0/component.json

Um...

Why is it checking BitBucket? This is breaking every install I'm trying to do now :(

jonathanong commented 10 years ago

it's because that version doesn't have a component.json: https://github.com/ripplejs/ripple/tree/0.23.0

:( needs better error message

anthonyshort commented 10 years ago

Woah, looks like the project has somehow fetched tags from another project.

jonathanong commented 10 years ago

yeah i was looking at that. how did it go from 8k commits to 80?

jonathanong commented 10 years ago

lol i think it's grabbing tags from here: https://github.com/ripple/rippled i wonder how that happened

kenany commented 10 years ago

Woah that was weird. Getting a 404 now though, haha.

anthonyshort commented 10 years ago

No idea. But a little worrying. Deleted all those and it's fine now.

netpoetica commented 10 years ago

@jonathanong Maybe there is a way to see if the return header is json or not before checking for malformed JSON? Or just do a check for 404s? This is the second one of these in the last few days :-) BitBucket really shouldn't be returning their 404 page on an API call though, kind of silly on atlassian - should be a JSON response like "resource unavailable" or something

jonathanong commented 10 years ago

you can't check for the content-type header because github doesn't send one. we'd have to handle every single remote separately -_-