componentjs / component

frontend package manager and build tool for modular web applications

https://github.com/componentjs/guide

MIT License

4.55k stars 306 forks source link

add --reload option on component build --watch #549

Closed wryk closed 10 years ago

wryk commented 10 years ago

514

vendethiel commented 10 years ago

shouldn't it imply --watch ?

wryk commented 10 years ago

actually --reload need an explicit --watch, should i make an implicit --watch on --reload ?

vendethiel commented 10 years ago

Either require it or make it implicit, imho.

vendethiel commented 10 years ago

Haha oh wow thanks @jonathanong :)

jonathanong commented 10 years ago

haha i always see you commenting and being helpful in every repo on github, so why not? :D

vendethiel commented 10 years ago

Travis failure looks like a transient failure ? Seems like it's #548

wryk commented 10 years ago

wow, @Nami-Doc in component organization, nice :3

first travis failure is my fault, but now it's just a malformed json from bitbucket on component install

jonathanong commented 10 years ago

yeah, i should fix that.

jonathanong commented 10 years ago

wow. one line fix. https://github.com/component/remotes.js/commit/ab232b578c51750706184ac5f2f7af1f8d141d38

vendethiel commented 10 years ago

I wonder thogh, should this really be in the core ? Do we consider it's a common enough case ? I see how --watch is useful for nearly every component but I'm not that sure for --reload

(I'm actually wondering if people later will come and ask for another option to change port and stuff haha)

jonathanong commented 10 years ago

dunno. sounds like more options ~_~

these option lists are getting too long.

i'm not even a big fan of reload. makes sense for css, but sometimes reloading js just messes things up. but i think it's important for a lot of devs workflow.

jonathanong commented 10 years ago

anyone wanna try this out?

tj commented 10 years ago

I'm not sure we even need watch really, just introduces a race between viewing something and having it build, vs building on demand

jonathanong commented 10 years ago

it's for components though. apps shouldn't be using it, but components don't have middleware to build on demand.

tj commented 10 years ago

ah yeah true that makes more sense

hallas commented 10 years ago

having played around with a few webkit apps I really love watch, and for dev flow, I guess live reload is a neat feature

wryk commented 10 years ago

i forget that pull request i rebuild and now travis pass, others things to add ?

trevorgerhardt commented 10 years ago

Looks good to me

chemzqm commented 10 years ago

How to let the users know that they should add livereload script in the html file to make livereload works?

wryk commented 10 years ago

I'll add a note in component/guide api.md file tonight

wryk commented 10 years ago

tonigth

ah ah ah ah :< component/guide@c55b9a4