Splitting path correctly on Windows

componentjs / component

frontend package manager and build tool for modular web applications

https://github.com/componentjs/guide

MIT License

4.55k stars 306 forks source link

Splitting path correctly on Windows #596

Closed brendanator closed 9 years ago

brendanator commented 9 years ago

Running component tsc on Windows fails with the error message component-tsc(1) does not exist. This is because it splits the PATH on : which doesn't work well with ; separated paths beginning C:

The fix to make this portable on different operating systems is to just use path.delimiter

netpoetica commented 9 years ago

@timaschew I think we should merge this one in before a 1.0 release. This is just a good idea in general. I checked through the rest of the codebase and didn't find any other occurrences of splitting on ":" so this should solve the problem global.

Thanks for this pull request! Nice catch!