search

componentjs / spec

Component specs
34 stars 4 forks source link

component-install does not add to component.json if it exists in ./component #19

Closed jonathanong closed 10 years ago

jonathanong commented 10 years ago

https://github.com/component/component/issues/405

i don't know what this means... why would there be a component/ folder? or are we going to make that a thing?

dominicbarnes commented 10 years ago

My first thought is that it's just a simple typo, and he meant to type ./components.

However, if that's the case, I have no idea how a component would end up in ./components without being component-install-ed (which updates the component.json automatically)

jonathanong commented 10 years ago

yeah wtf. i'm going to close this lol

TooTallNate commented 10 years ago

This is a valid bug. I've noticed it before too. If the dir already exists, but not in the component.json, then an entry should be added to the deps, but currently it does not

yields commented 10 years ago

+1 this should be fixed, and it should be reopened in component/component it has nothing to do with spec IMHO.

jonathanong commented 10 years ago

thanks for explanation