components / ember-data

Shim repository for EmberJS's Data component.
15 stars 53 forks source link

Bower: ember-data marked as incompatible with ember 1.2 #18

Closed johanneswuerbach closed 10 years ago

johanneswuerbach commented 10 years ago

After https://github.com/components/ember-data/commit/0386da865ec3e2d22903663c885209cfa41cdf93 bower marks ember versions > 1.0 as incompatible. ~1 was allowing ember 1.2.0.

> bower -v
1.2.8

screenshot 2013-12-19 14 08 25

johanneswuerbach commented 10 years ago

Bower is using node-semver and the say:

~1.2   := >=1.2.0-0 <1.3.0-0 "Any version starting with 1.2"
^1.2   := >=1.2.0-0 <2.0.0-0 "Any version compatible with 1.2"
1.2.x  := >=1.2.0-0 <1.3.0-0 "Any version starting with 1.2"
~1     := >=1.0.0-0 <2.0.0-0 "Any version starting with 1"
^1     := >=1.0.0-0 <2.0.0-0 "Any version compatible with 1"
1.x    := >=1.0.0-0 <2.0.0-0 "Any version starting with 1"

So ~1 was fine.

rwjblue commented 10 years ago

Will fix before re-tagging.

Thanks for tracking down the docs and confirming the right way to do this.

rwjblue commented 10 years ago

Just re-tagged 1.0. Thanks again!