components / ember-data

Shim repository for EmberJS's Data component.
15 stars 53 forks source link

Latest beta and canary distributions don't contain ember-data.js.map #32

Closed marcoow closed 8 years ago

marcoow commented 8 years ago

We're using the following ember-try configs for the simplabs/ember-simple-auth tests:

{
  name: 'ember-beta',
  dependencies: {
    'ember': 'components/ember#beta',
    'ember-data': 'components/ember-data#beta'
  },
  resolutions: {
    'ember': 'beta',
    'ember-data': 'beta'
  }
},
{
  name: 'ember-canary',
  dependencies: {
    'ember': 'components/ember#canary',
    'ember-data': 'components/ember-data#canary'
  },
  resolutions: {
    'ember': 'canary',
    'ember-data': 'canary'
  }
}

The latest beta and canary branches don't contain the ember-data.js.map file though, causing Ember CLI to fail with:

ENOENT, no such file or directory '/home/travis/build/simplabs/ember-simple-auth/tmp/funnel-input_base_path-r4FlWJx6.tmp/0/bower_components/ember-data/ember-data.js.map'

See the travis build for reference: https://travis-ci.org/simplabs/ember-simple-auth/builds/91904720

offirgolan commented 8 years ago

Bump. Having the same issue on my end as well.

Ember try config:

{
    name: 'ember-beta',
    dependencies: {
      'ember': 'components/ember#beta',
      'ember-data': 'components/ember-data#beta'
    },
    resolutions: {
      'ember': 'beta',
      'ember-data': 'beta'
    }
  }
rwjblue commented 8 years ago

I'm not sure if @fivetanley has started work on this yet, I'll double check with him to see...

fivetanley commented 8 years ago

We do not intend to support sourcemaps for the globals build going forward.

fivetanley commented 8 years ago

We will likely need to make the sourcemap optional (detect if it is there) in the 2.3.0-betas npm modules if you are using bower.

rwjblue commented 8 years ago

Should be fixed by https://github.com/emberjs/data/pull/3944.

rwjblue commented 8 years ago

OK, the ember-data.js.map file is now present in canary branch and beta branch is being updated now. Closing this, but I'm happy to reopen if folks are still having issues.

offirgolan commented 8 years ago

That seemed to fix it. Thanks guys for the quick fix! :100:

marcoow commented 8 years ago

👍