search

components / ember-data

Shim repository for EmberJS's Data component.
15 stars 53 forks source link

Add license field to bower.json #33

Closed nickiaconis closed 8 years ago

nickiaconis commented 8 years ago

bower.json is missing the license field. If I'm not mistaken, Ember Data uses the same license as Ember (MIT). https://github.com/components/ember/blob/master/bower.json#L3

Our automated external library requests service is blocking the import of Ember Data canary for this reason.

rwjblue commented 8 years ago

This looks good, but we also need to update these files https://github.com/emberjs/data/tree/master/config/package-manager-files.

nickiaconis commented 8 years ago

Ah, I did not know these were generated (but that would make sense). Thanks for setting me straight. I've posted a new PR for those files: emberjs/data#3980.

rwjblue commented 8 years ago

I believe that both the PR in Ember Data AND this one are needed. The PR to Ember Data pushes to release, beta, and canary branches here, but not master.

nickiaconis commented 8 years ago

Oh, okay. Good to know. Thanks! On Dec 9, 2015 6:40 AM, "Robert Jackson" notifications@github.com wrote:

Merged #33 https://github.com/components/ember-data/pull/33.

— Reply to this email directly or view it on GitHub https://github.com/components/ember-data/pull/33#event-486967989.