search

components / foundation

Shim repository for Foundation.
http://foundation.zurb.com/
11 stars 13 forks source link

Changed "scss" property to "files" #14

Closed azhang closed 10 years ago

azhang commented 10 years ago

Currently the scss files do not get downloaded when running component install. They must be listed in a "files" property in order for this to occur. https://github.com/component/component/issues/471

azhang commented 10 years ago

Also updated to 5.0.3

ericlemerdy commented 10 years ago

Re-order your commits in master. You can rebase through.

Thank you for your fix and the 5.0.3 update :cool:

azhang commented 10 years ago

Sorry, since this was my first pull request I wasn't aware that it would track the branch until it was actually pulled. I wasn't sure about commit e246dae, and have since discovered that it isn't good ("styles" should list .css and "files" should list .scss as I originally had it). Hence, it should not be merged.

ericlemerdy commented 10 years ago

Fixed with 457d987836b81199bb7c062309f71ae79b39d708 for 5.0.2 and merged in 5.0.3 with 67c79753cb3eaacdca0898f6add704507fbbc9b4. Does it feels good now ?

azhang commented 10 years ago

Yup, awesome thanks!