search

components / modernizr

Shim repository for Modernizr.
http://modernizr.com
Other
9 stars 9 forks source link

Minified versions #3

Open Restless-ET opened 9 years ago

Restless-ET commented 9 years ago

Hello

If you don't mind me asking... why this component does not have a minified version available? Many of the other components have minified versions such as bootstrap, jquery, font-awesome, etc.

Is there any impediment for this one?

martinlindhe commented 9 years ago

I am not sure i can give a correct answer, but i guess that these files are basically wrapped up in a package from http://modernizr.com/, and since they dont provide a minified version, none exist here. they also dont seem to provide any "standard" download (its all customizable), so i'm not really sure what has been put in here.

if you want minified versions you could easily plug in this modernizr.js into your gulp/grunt build script that concats & minifies your other js resources, instead of relying on .min.js files provided to you

Restless-ET commented 9 years ago

Hmm.. I see.. still, I think we could provide here a minified version assuming that all checkboxes available at http://modernizr.com/download/ under CSS3, HTML5 and Misc. sections are toggled on (then even have a button to toggle all of them at once for each section).

And I'm aware than I can minify this myself but I thought that a minified version would be a nice addition here specially since that's what already happens with other components fetched using composer and people might already be used to that behaviour.

Also I think that most people ends up checking everything on link above before downloading...

Anyway, this is just a suggestion. :-)

RobLoach commented 9 years ago

@Restless-ET Feel free to open up a PR and someone can merge it in :+1: .