Open KeithHenry opened 5 years ago
I've found what using allow="sync-xhr 'none'"
breaks: when selecting job boards to search you get an Error: No search boards specified message even when boards are selected.
We can work around this, but it's worth being aware: when selecting a board the pop up that appears loads with a synchronous request that can hang the calling page until it completes. As this follows user interaction we can hide it, but animations (for instance loading spinners) will stall - we can just make sure the calling page isn't animating anything before the <iframe>
starts to load.
Thanks @KeithHenry for letting us know that. @vadimkuragkovskiy - let's take a closer look at that.
When you load the
<iframe>
one of the many console log messages you get is this:Full log:
This appears to be due to a jQuery
$.ajax
call in https://cdn.v3.idibu.com/assets/app_6633cdef58ff11f13509b3c753e1cb0f3e2e8a03_ae9f84d2ed07b1334d389644f953708e.jsThis causes the main JS thread to hang in the
<iframe>
and in turn the calling app. It appears to be unnecessary too as it's in aneach
loop where the result is not being used, but it's hard to tell with the minified code.We can avoid this in some browsers with a feature policy on the
<iframe allow="sync-xhr 'none'">
but that risks breaking whatever Idibu expects to stall the main thread for.