search

compor / llvm-ir-cmake-utils

LLVM IR CMake utils for bitcode file manipulation by opt and friends
GNU Lesser General Public License v2.1
68 stars 14 forks source link

Skip header files in llvmir_attach_bc_target #22

Closed tandf closed 1 year ago

tandf commented 1 year ago

When header files are used in add_executable(), it's better to exclude them from llvm in files and set their path as include path.

compor commented 1 year ago

Hi there thanks for this, but could you please open an issue so we can discuss further the need for this patch there?

EDIT: Discussion move to #24

compor commented 1 year ago

Hey @tandf one last thing. Could you please remove the previous commit and rebase based only on the last one after my feedback?

I'd prefer to have a linear history and no superfluous commits from development.

tandf commented 1 year ago

Sure, I'll remove and rebase the commit.