Closed tandf closed 1 year ago
@tandf thanks for the details explanation and sorry for the delay; I've left some minor comments.
@compor Thanks for the comments. I just added two replies to your comments.
Hi again, sorry for being pedantic, but I'm in the unique position of not remembering the implementation very well ;-) so things like that stand out, so why not fix them eh?
Thanks for the comments. I just submitted a new commit for resolving the comments. For the details, please refer to the commit and my comments. Please help me review it when you have time. Thanks!
If it looks good to you, I can combine the two commits into one before merging this pr.
The commits are combined
Addressed by #28 Thanks!
Hi compor,
In
llvmir_attach_bc_target
, to get the absolute path of the in-file, currentlyget_filename_component
is used: https://github.com/compor/llvm-ir-cmake-utils/blob/01fadd72be92c8342af299618ad71653746f4b72/cmake/LLVMIRUtil.cmake#L179According to the doc,
get_filename_component
resolves the absolute path based on theCMAKE_CURRENT_SOURCE_DIR
variable.However, the
CMAKE_CURRENT_SOURCE_DIR
variable doesn't always stand for the path where theDEPENDS_TRGT
is defined. To handle the cases whereCMAKE_CURRENT_SOURCE_DIR
is messed up, I propose to instead explicitly look for the source path ofDEPENDS_TRGT
, i.e. use the SOURCE_DIR:For normal cases where the
CMAKE_CURRENT_SOURCE_DIR
variable is not messed up, it should contain the same value asSOURCE_DIR
.I have submitted a pull request for this change, see #28. Please let me know if you have any question. Thanks!