search

composablesys / collabs

Collabs library monorepo
https://collabs.readthedocs.io/
Apache License 2.0
246 stars 11 forks source link

adding TLS (i.e., support for WSS) to collabs-ws-server #277

Closed rozek closed 2 months ago

rozek commented 3 months ago

First of all: thank you very much for your excellent work!

However, one of the features I was missing was transport layer security for your collabs-ws-server.

Fortunately, it wasn't very difficult to add WSS support to your script (your code is well separated!) so I just did that.

While I cannot build the whole collabs project (do you require an old version of Node.js?), the server itself seems to work fine.

Thus, if you are interested, you may just add my pretty small contribution to your project.

Wit greetings from Germany,

Andreas Rozek

mweidner037 commented 2 months ago

Thanks for this!

I'd like to leave TLS out of the built-in collabs-ws-server command to keep it simple, but I can link to your fork as an example of how to customize it.

While I cannot build the whole collabs project (do you require an old version of Node.js?)

I believe there was an issue with monorepos in some versions of npm; I'll see if I can get it working with the latest version.

mweidner037 commented 2 months ago

Moved to https://github.com/composablesys/collabs/issues/280

rozek commented 2 months ago

Thanks for the link - although I don't agree that my changes made the original websocket server so much more difficult (given that today's browsers make more and more difficulties when contacting other servers without TLS)