search

compose-spec / compose-go

Reference library for parsing and loading Compose YAML files
https://compose-spec.io
Apache License 2.0
355 stars 112 forks source link

run interpolation after merge, but for required attributes #651

Closed ndeloof closed 3 months ago

ndeloof commented 3 months ago

interpolation is ran after merge, so that a required missing variable, which is actually overridden, won't produce an error.

This is an alternative implementation based on https://github.com/compose-spec/compose-go/pull/644: This PR always run interpolation applying extends and include, but only on the relevant configuration structures. Global interpolation eventually takes places after merge

This has a minor impact on the loading process and schema: as we don't interpolate, we can't rely on a canonical model to enforce unicity after compose file merge, and doing so compose-spec schema uniqueItem constraint must be removed. This one anyway is just a syntactic sugar AFAICT that has no real impact on usability. From an IDE point of view, while obvious duplicate can be detected by schema, the non-obvious ones (like ports: ["8080", "${PORT}"] can't, and we still have to implement unicity check by the code

close https://github.com/docker/compose/issues/11925

ndeloof commented 3 months ago

see https://github.com/compose-spec/compose-go/pull/652

ndeloof commented 3 months ago

checked by https://github.com/docker/compose/pull/11961