search

compose-spec / compose-go

Reference library for parsing and loading Compose YAML files
https://compose-spec.io
Apache License 2.0
355 stars 112 forks source link

Revert "run interpolation after merge, but for required attributes" #666

Closed idsulik closed 3 months ago

idsulik commented 3 months ago

This reverts commit 65600cee45d45771a1faa6ddaf87b23ca4d2400c.

The commit led to this issue https://github.com/docker/compose/issues/12001, a quick fix is to revert the commit and release it.

ndeloof commented 3 months ago

We only do such revert if there's no reasonable fix to offer. For those impacted it is easy to just keep running older docker compose release

idsulik commented 3 months ago

We only do such revert if there's no reasonable fix to offer. For those impacted it is easy to just keep running older docker compose release

Okay, I got it. It was just a quick fix. I think it'll be better to revert and release if we don't be able to fix it asap, because more and more users download the latest version and a lot of them will be forced to downgrade or spent time figuring out what went wrong

ndeloof commented 3 months ago

Sure. A fix is proposed by @jhrotko here : https://github.com/compose-spec/compose-go/pull/667

idsulik commented 3 months ago

Great!

jhrotko commented 3 months ago

there are more issues than in #667

ndeloof commented 3 months ago

indeed. I've been investigating https://github.com/docker/compose/issues/12001 and can't find a simple fix. I suggest we revert this and introduce test cases to cover the identified issues, so that next attempt (would be 3rd one 😓) to implement "interpolate after merge" would be safer.