compose-x / ecs_composex

Manage, Configure and Deploy your services and AWS services and applications from your docker-compose definitions
https://docs.compose-x.io
Mozilla Public License 2.0
165 stars 17 forks source link

[FR] Improve x-acm exception message #543

Closed JohnPreston closed 2 years ago

JohnPreston commented 2 years ago

2021-10-22 11:17:22 [INFO], Matched acm:certificate to AWS Resource
--
965 | Traceback (most recent call last):
966 | File "/root/.pyenv/versions/3.8.10/bin/ecs-compose-x", line 8, in <module>
967 | sys.exit(main())
968 | File "/root/.pyenv/versions/3.8.10/lib/python3.8/site-packages/ecs_composex/cli.py", line 172, in main
969 | root_stack = generate_full_template(settings)
970 | File "/root/.pyenv/versions/3.8.10/lib/python3.8/site-packages/ecs_composex/ecs_composex.py", line 450, in generate_full_template
971 | init_acm_certs(settings, dns_settings, root_stack)
972 | File "/root/.pyenv/versions/3.8.10/lib/python3.8/site-packages/ecs_composex/acm/acm_stack.py", line 157, in init_acm_certs
973 | mappings = create_acm_mappings(lookup_resources, settings)
974 | File "/root/.pyenv/versions/3.8.10/lib/python3.8/site-packages/ecs_composex/acm/acm_stack.py", line 135, in create_acm_mappings
975 | cert_config = lookup_cert_config(res.logical_name, res.lookup, settings.session)
976 | File "/root/.pyenv/versions/3.8.10/lib/python3.8/site-packages/ecs_composex/acm/acm_aws.py", line 85, in lookup_cert_config
977 | config = get_cert_config(logical_name, cert_arn, lookup_session)
978 | File "/root/.pyenv/versions/3.8.10/lib/python3.8/site-packages/ecs_composex/acm/acm_aws.py", line 51, in get_cert_config
979 | validate_certificate_status(cert_r["Certificate"])
980 | File "/root/.pyenv/versions/3.8.10/lib/python3.8/site-packages/ecs_composex/acm/acm_aws.py", line 32, in validate_certificate_status
981 | raise ValueError(
982 | ValueError: The certificate arn:aws:acm:eu-west-1:000000000000:certificate/66712010-e0d1-4b49-b49d-50d543c21ebc is not valid.

The certificate is still ongoing validation, catch exception RequestInProgressException and explain why instead of just saying it is not valid.