compose-x / ecs_composex

Manage, Configure and Deploy your services and AWS services and applications from your docker-compose definitions
https://docs.compose-x.io
Mozilla Public License 2.0
168 stars 17 forks source link

Use official nginx-prometheus-exporter image #570

Closed lucacome closed 2 years ago

lucacome commented 2 years ago

Use the new official image from NGINX.

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

JohnPreston commented 2 years ago

Thanks @lucacome for the PR ! Glad to see the official image published to AWS Public ECR. I can now also remove that repo :)

Did you get a chance to test it with it ?

lucacome commented 2 years ago

Hi @JohnPreston

no I didn’t get a chance to test it, I'm not very familiar wit the project and didn't see an easy way to test it, I just saw the reference in AWS Public ECR and I thought I would let you know there's an official version of the exporter now 😃

I also see that there's a test failing, let me know if I can do anything to fix that.

JohnPreston commented 2 years ago

Hi @JohnPreston

no I didn’t get a chance to test it, I'm not very familiar wit the project and didn't see an easy way to test it, I just saw the reference in AWS Public ECR and I thought I would let you know there's an official version of the exporter now 😃

I also see that there's a test failing, let me know if I can do anything to fix that.

Great news to see a official image there. Only aimed to fill the gap pending that official release.

No, the issue is no yours at all, in the middle of some more in depths changes to some aspects of the project.

Thanks for the PR, and should you have any questions about the project do let me know