search

compose-x / ecs_composex

Manage, Configure and Deploy your services and AWS services and applications from your docker-compose definitions
https://docs.compose-x.io
Mozilla Public License 2.0
158 stars 16 forks source link

[BUG] elbv2 with empty DefaultActions crashes on target with Conditions #697

Closed thorfi closed 8 months ago

thorfi commented 8 months ago

Fixes #696

sonarcloud[bot] commented 8 months ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

JohnPreston commented 8 months ago

Hi @thorfi Thanks for this. I presume this then works for you when you do not set access and only set Conditions? If that's the case, considering the tests failing are my own doing, happy to merge :+1:

thorfi commented 8 months ago

@JohnPreston hey, yes, exactly, it now works if I only set Conditions and don't set access. :-)