search

compose-x / ecs_composex

Manage, Configure and Deploy your services and AWS services and applications from your docker-compose definitions
https://docs.compose-x.io
Mozilla Public License 2.0
158 stars 16 forks source link

[BUG] x-cloud: should generate Vpc: Ref: VpcID #705

Closed thorfi closed 8 months ago

thorfi commented 8 months ago

Fixes #704

sonarcloud[bot] commented 8 months ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

thorfi commented 8 months ago

Hi @JohnPreston ,

Same deal as the last one, tiny few lines bugfix.

JohnPreston commented 8 months ago

Hi @JohnPreston ,

Same deal as the last one, tiny few lines bugfix.

Hey, thanks @thorfi Can you check my questions in the issue itself?

EDIT: I can see the change fixes it for cloudmap, looking if there is somewhere else this notation wouldn't be working.

JohnPreston commented 8 months ago

Alright, considering that making x-vpc::<attribute> notation with Lookup looks like a fair bit of work, but the VpcId parameter will always be set to the cloudmap stack when creating a new private zone, I suppose this change makes sense and will always work.

JohnPreston commented 8 months ago

@thorfi Feel free to join on slack as this might make exchange a little faster. Thanks for the report and the bug fix as always,