[BUG] ECS ContainerDefinition has broken Environment entries for Secrets

compose-x / ecs_composex

Manage, Configure and Deploy your services and AWS services and applications from your docker-compose definitions

https://docs.compose-x.io

Mozilla Public License 2.0

165 stars 17 forks source link

Closed thorfi closed 10 months ago

thorfi commented 10 months ago

Fixes #707

@JohnPreston

I know this is is a bit of a dirty hack - I don't expect you to accept this fix necessarily.

I can confirm that it does work though, so removing whatever is creating the Environment: entries should do the same thing.

JohnPreston commented 10 months ago

I presume the ELB changes in here are due to a rebase/merge you'd done from the other branch?

thorfi commented 10 months ago

Oops yes, those are from your fixes for #696 that I pulled to test. If you merge that they should go away.

thorfi commented 10 months ago

@JohnPreston - I updated my branch to your main so the diff is correct now

thorfi commented 10 months ago

Closing this PR as no longer needed

sonarcloud[bot] commented 10 months ago

Kudos, SonarCloud Quality Gate passed!

No Coverage information
No Duplication information